[WTF-2115] Generate types for editable images and files#159
Open
alihcsumer wants to merge 6 commits intomasterfrom
Open
[WTF-2115] Generate types for editable images and files#159alihcsumer wants to merge 6 commits intomasterfrom
alihcsumer wants to merge 6 commits intomasterfrom
Conversation
Collaborator
|
To include the new types we will need to raise the minimum version of the |
1ecf75b to
44ddc00
Compare
44ddc00 to
52b27e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅ ❌This PR contains
What is the purpose of this PR?
It will be possible to edit file and image properties. This PR updates the typing accordingly.
Relevant changes
Type generation will now consider allowUpload attribute in the XML to generate the typings for file and image properties.
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required